feat(Tab): trim value/text #5701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request improves data handling and formatting in the Updated class diagram for SelectedItemclassDiagram
class SelectedItem {
+string Value
+string Text
+SelectedItem(string value, string text)
}
note for SelectedItem "Value and Text are now trimmed in MultiSelect.razor.cs"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- This change looks good, but I'm wondering if trimming the values might have unintended consequences for users who rely on specific whitespace.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5701 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29806 29806
Branches 4225 4225
=========================================
Hits 29806 29806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5700
Summary By Copilot
This pull request includes changes to improve the data handling and formatting in the
MultiSelectcomponent. The key changes focus on ensuring that IDs are correctly used and that text values are properly trimmed.Changes to data handling and formatting:
src/BootstrapBlazor.Server/Components/Samples/MultiSelects.razor.cs: Modified theOnQueryAsyncmethod to usei.Id.ToString()instead ofi.Name!for theSelectedItemID.src/BootstrapBlazor/Components/Select/MultiSelect.razor.cs: Updated theGetItemsByVirtualizemethod to trim values and text before adding them to theSelectedItem.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improves data handling and formatting in the MultiSelect component by ensuring IDs are correctly used and text values are properly trimmed.